Bug 11068 - [PATCH] - Ability to have user defined data formats
Summary: [PATCH] - Ability to have user defined data formats
Status: CLOSED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: Other other
: P3 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-23 00:27 UTC by Shawn Laubach
Modified: 2004-11-16 19:05 UTC (History)
0 users


Attachments
Code patch to add number formatting (and my name to developer list) (9.32 KB, patch)
2002-07-23 00:28 UTC, Shawn Laubach 		Details | Diff
Test xls file for the test I added to workbook. (13.50 KB, application/octet-stream)
2002-07-23 00:29 UTC, Shawn Laubach 		Details
New Patch (22.07 KB, patch)
2002-07-26 02:05 UTC, Shawn Laubach 		Details | Diff
Data Example (3.79 KB, text/plain)
2002-07-26 02:05 UTC, Shawn Laubach 		Details
The newest patch. Patches other things that I broke by instantiating HSSFDataFormat (26.12 KB, patch)
2002-07-27 16:35 UTC, Shawn Laubach 		Details | Diff
Example code and test file to use zipped up nicely (3.07 KB, application/octet-stream)
2002-07-27 16:36 UTC, Shawn Laubach 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Laubach 2002-07-23 00:27:52 UTC 
Heres the code mentioned ealier on the dev mailing list.
Comment 1 Shawn Laubach 2002-07-23 00:28:29 UTC 
Created attachment 2440 [details]
Code patch to add number formatting (and my name to developer list)
Comment 2 Shawn Laubach 2002-07-23 00:29:01 UTC 
Created attachment 2441 [details]
Test xls file for the test I added to workbook.
Comment 3 Shawn Laubach 2002-07-26 02:04:32 UTC 
Ignore previous patch.  I went with the suggestion on the developers list and 
set it up where you create a instance of  HSSFDataFormat.  The test file is 
still valid.  I've also will include an example and updated the quick-guide 
with the example.
Comment 4 Shawn Laubach 2002-07-26 02:05:04 UTC 
Created attachment 2493 [details]
New Patch
Comment 5 Shawn Laubach 2002-07-26 02:05:40 UTC 
Created attachment 2494 [details]
Data Example
Comment 6 Andy Oliver 2002-07-27 00:54:45 UTC 
Hi Shawn.  After applying these patches all the unit tests failed and several
examples didn't compile.  Please run "./build.sh clean compile test", reopen and
resubmit the corrected patch.
Comment 7 Shawn Laubach 2002-07-27 16:34:20 UTC 
Please forgive me.  I found and fixed all the problems except one test still 
fails.  It is org.apache.poi.hpfs.basic.TestBasic or something like that.  
Since I didn't have anything to do with that, I just skipped it.  All other 
tests now pass and everything compiles.  Again, I'm sorry.
Comment 8 Shawn Laubach 2002-07-27 16:35:32 UTC 
Created attachment 2507 [details]
The newest patch.  Patches other things that I broke by instantiating HSSFDataFormat
Comment 9 Shawn Laubach 2002-07-27 16:36:21 UTC 
Created attachment 2508 [details]
Example code and test file to use zipped up nicely
Comment 10 Andy Oliver 2002-07-27 22:05:05 UTC 
cool I'll apply it later if glen or someone doesn't beat me to it...  I'm
sun-poisoned and exhausted.  Worked at Habitat for humanity today...  (volunteer
organization that builds houses for needy people)
Comment 11 Andy Oliver 2002-08-15 14:15:11 UTC 
applied, please cross check.  Sorry Shawn forgot about this... 

Applied portions by hand.  Made some stylistic changes in HSSFWorkbook (removed
predeclaring of "int i" in the for loop -- confusing...  removed predeclared
loop temp value...same reason)

Please cross check.