Bug 23190 - JNDIRealm doesn't escape search filters
Summary: JNDIRealm doesn't escape search filters
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 4
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 4.1.27
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
: 16541 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-09-16 10:43 UTC by Volker Schmidt
Modified: 2004-11-16 19:05 UTC (History)
1 user (show)


Attachments
Patch file with fix to do RFC 2254 encoding (1.94 KB, patch)
2003-12-11 00:10 UTC, Jeff Tulley 		Details | Diff
diff against JNDIRealmTestCase to unit test new RFC 2254 code (3.55 KB, patch)
2003-12-11 00:16 UTC, Jeff Tulley 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Schmidt 2003-09-16 10:43:47 UTC 
If the DN, which will be inserted into the search filter (for example DN of 
user in group search), contains a back slash character, the search won't work. 
This back slash character must be escaped according RFC2254.
Comment 1 Jeff Tulley 2003-12-10 19:59:14 UTC 
Yes, this is indeed a bug.  I will look into writing up a patch for it.
Comment 2 Jeff Tulley 2003-12-11 00:10:47 UTC 
Created attachment 9506 [details]
Patch file with fix to do RFC 2254 encoding
Comment 3 Jeff Tulley 2003-12-11 00:16:25 UTC 
Created attachment 9507 [details]
diff against JNDIRealmTestCase to unit test new RFC 2254 code
Comment 4 Yann Cébron 2003-12-11 08:16:25 UTC 
*** Bug 16541 has been marked as a duplicate of this bug. ***
Comment 5 Tim Funk 2003-12-11 17:12:03 UTC 
Just to confirm - this also would be a problem with 5? (Since the JNDIRealm code
is the same) - the patch looks ok to me. I'll try to patch on Friday.
Comment 6 Tim Funk 2003-12-12 21:40:56 UTC 
Fixed. Thanks jeff!
Comment 7 Tim Funk 2003-12-12 21:44:45 UTC 
Patch also ported to 5 . (So it will be in 5.0.17 whenever it is built)