Bug 27927 - Multiple file buckets delivered incorrectly by emulate_sendfile
Summary: Multiple file buckets delivered incorrectly by emulate_sendfile
Status: CLOSED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.0.49
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2004-03-25 00:01 UTC by Bojan Smojver
Modified: 2004-11-16 19:05 UTC (History)
0 users


Attachments
Fix for the multiple file bucket problem in emulate_sendfile() (444 bytes, patch)
2004-03-25 00:01 UTC, Bojan Smojver 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bojan Smojver 2004-03-25 00:01:10 UTC 
When multiple file buckets exist in a brigade that is to be sent out and
emulate_sendfile() is used to do it, some buckets may be misaligned (i.e. the
output will appear garbled). The issue is related to a missing apr_file_seek()
call when offset is 0 (i.e. emulate_sendfile() incorrectly assumes that it is at
the beginning of the file).

The patch that fixes that problem is attached.
Comment 1 Bojan Smojver 2004-03-25 00:01:45 UTC 
Created attachment 10966 [details]
Fix for the multiple file bucket problem in emulate_sendfile()
Comment 2 Cliff Woolley 2004-03-25 00:25:26 UTC 
This was committed to 2.1 by FirstBill and has received enough votes for 
backport to 2.0 as soon as somebody gets to it.

Thanks!
Cliff
Comment 3 Cliff Woolley 2004-03-25 00:25:40 UTC 
This was committed to 2.1 by FirstBill and has received enough votes for 
backport to 2.0 as soon as somebody gets to it.

Thanks!
Cliff
Comment 4 Jeff Trawick 2004-03-30 20:21:40 UTC 
fixed in stable branch as well as HEAD