Bug 28252 - Code cleanup (no fix)
Summary: Code cleanup (no fix)
Status: RESOLVED FIXED
Alias: None
Product: Taglibs
Classification: Unclassified
Component: I18N Taglib (show other bugs)
Version: unspecified
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-07 09:40 UTC by Patrick Samson
Modified: 2004-11-16 19:05 UTC (History)
0 users


Attachments
MessageTag patch (803 bytes, patch)
2004-06-02 14:47 UTC, Patrick Samson 		Details | Diff
BundleTag patch (589 bytes, patch)
2004-06-02 14:49 UTC, Patrick Samson 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Samson 2004-04-07 09:40:50 UTC 
In MessageTag.java:
- Remove unused:
import java.util.Locale;

- Add in release():
        _bundleRef = null;
        _args = null;
        _debug = false;
        _messageFormat = null;
        _arguments = null;
- Replace in doStartTag():
EVAL_BODY_TAG with EVAL_BODY_BUFFERED

In BundleTag.java:
- Remove unused:
import javax.naming.InitialContext;
import javax.naming.NamingException;
Comment 1 Martin Cooper 2004-04-07 18:48:36 UTC 
Please supply patches created using 'cvs diff -u'. That makes it much simpler 
for us to apply them. Thanks.
Comment 2 Felipe Leme 2004-05-22 13:56:33 UTC 
Patrick,

Please provided the patch as Martin indicated, but also have in mind that the
taglib requirement is JSP 1.1, not 1.2, so we cannot change the return to
EVAL_BODY_BUFFERED.

Regards,

Felipe
Comment 3 Patrick Samson 2004-05-28 19:40:10 UTC 
OK, will try to find some time to do the diff.
Right now, I don't have any CVS soft. I guess
I have to learn this stuff.
Give me some time..
Or.. is there a quicker way via a cvs web interface?
Comment 4 Felipe Leme 2004-05-29 01:00:08 UTC 
CVS might be a little bit intimidating at first, but once you get used to it,
it's a breeze.

Regarding the web, yes, there is a cvsweb interface, but it won't work for patches.
Comment 5 Patrick Samson 2004-06-02 14:47:54 UTC 
Created attachment 11727 [details]
MessageTag patch
Comment 6 Patrick Samson 2004-06-02 14:49:35 UTC 
Created attachment 11728 [details]
BundleTag patch
Comment 7 Felipe Leme 2004-06-04 04:32:11 UTC 
Applied changes to CVS, thanks for the patch.