Created attachment 16812 [details] [PATCH] TXT rendering is supported
I've had a look at this patch. The output looks quite good on most files I checked so far. The border and background painting stuff is very cool. However, you might want to look at examples/fo/basic/readme.fo where the page numbers are not quite in the right place. And examples/fo/basic/list.fo has a problem on the last page. Anyway, the above is not a big problem right now. What I'd like you to do is revisit the patch and change the following: - Convert all tab characters to spaces. We don't allow tab characters in our codebase. It would be best if you installed Checkstyle 3.5 and checked your code against the rules found in the FOP root directory. - I'd like to see a little more javadocs (to fix the Checkstyle warnings I get). We're trying to gradually fix all the warnings as we go and I'd not want to introduce too many new ones. Would you please post a revised patch fixing the two issues above? Thanks! Another thing that should be looked (not mandatory IMO) at are the warnings due to the getValue() calls without a PercentBaseContext. I don't say what you did was wrong and the warning shouldn't be issued. However, I think your code doesn't handle percentages right now. On the other side, I'm not sure how to properly handle this case in TXTHandler.
Created attachment 16923 [details] Fixed previous patch for txt Sorry for a lot of warnings. Fixed.
(In reply to comment #2) > I've had a look at this patch. The output looks quite good on most files I > checked so far. The border and background painting stuff is very cool. However, > you might want to look at examples/fo/basic/readme.fo where the page numbers are > not quite in the right place. Here footer string size ("This is not the latest Fop documentation, but just an fo example. FOP - p. ") is too long, so page number is in the wrong place. Delete one character from this string and you'll get correct output. >And examples/fo/basic/list.fo has a problem on the last page. Fixed. > Anyway, the above is not a big problem right now. What I'd like you to do is > revisit the patch and change the following: > - Convert all tab characters to spaces. We don't allow tab characters in our > codebase. It would be best if you installed Checkstyle 3.5 and checked your code > against the rules found in the FOP root directory. > - I'd like to see a little more javadocs (to fix the Checkstyle warnings I get). Fixed. > We're trying to gradually fix all the warnings as we go and I'd not want to > introduce too many new ones. > Would you please post a revised patch fixing the two issues above? Thanks! > Another thing that should be looked (not mandatory IMO) at are the warnings due > to the getValue() calls without a PercentBaseContext. I don't say what you did > was wrong and the warning shouldn't be issued. However, I think your code > doesn't handle percentages right now. On the other side, I'm not sure how to > properly handle this case in TXTHandler. Me too. Sorry, but I have no time to resolve it now.
Thanks a lot for your patience, Sergey. I've applied your patch. It looked fine and the output is also better. The revision for the patch: http://svn.apache.org/viewcvs?rev=332141&view=rev I've added an encoding feature that was present in the maintenance branch: http://svn.apache.org/viewcvs?rev=332144&view=rev The remaining "problem" can be fixed later. It doesn't have to be perfect, yet.
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed