Bug 39674 - service.bat did not check jrockit's jvm.dll
Summary: service.bat did not check jrockit's jvm.dll
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Native:Integration (show other bugs)
Version: 5.5.17
Hardware: All other
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords: JDK1.5
Depends on:
Blocks:
 
Reported: 2006-05-29 14:17 UTC by lizongbo
Modified: 2006-06-15 11:55 UTC (History)
0 users


Attachments
the file had added code for check jrockit's jvm.dll (3.99 KB, patch)
2006-05-29 14:22 UTC, lizongbo 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lizongbo 2006-05-29 14:17:56 UTC 
in service.bat , the code follow:

set PR_JVM=%JAVA_HOME%\jre\bin\server\jvm.dll
if exist "%PR_JVM%" goto foundJvm
rem Set the client jvm from JAVA_HOME
set PR_JVM=%JAVA_HOME%\jre\bin\client\jvm.dll
if exist "%PR_JVM%" goto foundJvm

but this code did not check jrockit's jvm.dll.
and jrockit neither have directory "server" nor have  directory "client" ,but
noly have  directory "jrockit" .
eg:
D:\Java\jrockit-R26.3.0-jdk1.5.0_06\jre\bin\jrockit\jvm.dll


when set JAVA_HOME to jrockit for windows service and statr it ,it could not
started .
errot message: "Apache Tomcat 服务因 0 (0x0) 服务性错误而停止。"


so the bat file  should add follow code:

-------------
set PR_JVM=%JAVA_HOME%\jre\bin\jrockit\jvm.dll
if exist "%PR_JVM%" goto foundJvm
-------------

to be  follow:


set PR_JVM=%JAVA_HOME%\jre\bin\server\jvm.dll
if exist "%PR_JVM%" goto foundJvm
rem Set the client jvm from JAVA_HOME
set PR_JVM=%JAVA_HOME%\jre\bin\client\jvm.dll
if exist "%PR_JVM%" goto foundJvm
set PR_JVM=%JAVA_HOME%\jre\bin\jrockit\jvm.dll
if exist "%PR_JVM%" goto foundJvm


:)
Comment 1 lizongbo 2006-05-29 14:22:01 UTC 
Created attachment 18361 [details]
the file  had  added code for check jrockit's jvm.dll
Comment 2 Yoav Shapira 2006-06-15 18:55:59 UTC 
Good suggestion: I've implemented it for the next release.  Thank you.