Bug 44097 - [PATCH] Replace function in formula cell
Summary: [PATCH] Replace function in formula cell
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-18 17:43 UTC by Manda Wilson
Modified: 2007-12-21 04:24 UTC (History)
0 users



Attachments
Generated using svn diff > FormulaReplaceFunction.patch (4.48 KB, patch)
2007-12-18 17:44 UTC, Manda Wilson
Details | Diff
Contains the files I modified to implement and test the REPLACE function. (40.91 KB, application/x-gzip)
2007-12-18 17:46 UTC, Manda Wilson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manda Wilson 2007-12-18 17:43:17 UTC
I have implemented the REPLACE function for formula cells.  

I have also filled in the REPLACE "FORMULA" and "EXPECTED VALUE" rows of the file
src/scratchpad/testcases/org/apache/poi/hssf/data/FormulaEvalTestData.xls with
17 test cases.  All tests pass.
Comment 1 Manda Wilson 2007-12-18 17:44:40 UTC
Created attachment 21283 [details]
Generated using svn diff > FormulaReplaceFunction.patch

This is a patch file, generated by running:

svn diff > FormulaReplaceFunction.patch

After I finished implementing the REPLACE function.
Comment 2 Manda Wilson 2007-12-18 17:46:28 UTC
Created attachment 21284 [details]
Contains the files I modified to implement and test the REPLACE function.

Contains the files I modified to implement and test the REPLACE function.

This tar file contains two files that I modified to implement and test the
REPLACE
formula function.  

The first file is:

src/scratchpad/src/org/apache/poi/hssf/record/formula/functions/Replace.java

This is where the REPLACE function is implemented.

The second file is:

src/scratchpad/testcases/org/apache/poi/hssf/data/FormulaEvalTestData.xls

I modified two rows in this file (rows 1120 and 1121), the "FORMULA" and
"EXPECTED VALUE" rows for the replace function.  This row contains the test
cases
for replace.  These tests run successfully and are run automatically when the
ant
task "test" is executed.
Comment 3 Nick Burch 2007-12-21 04:24:58 UTC
Thanks, applied