Created attachment 21949 [details] Patch for mod_filter.c, mod_request.c, mod_request.h Several additional changes are needed to make mod_request build correctly on all platforms: 1. Only the module symbol "request_module" should be exported, all other symbols should be private. 2. Other modules may include mod_request.h to access the optional functions, so it must not contain a module declaration. The declaration should only be in mod_request.c 3. mod_filter.c:149 requires a cast for ap_expr_string on platforms where AP_DECLARE specifies a non-default linkage (this cast is benign on Unix). The attached trunk patch addresses these issues.
Created attachment 21950 [details] Windows project file for mod_request (trunk) For Windows build, these changes are also needed: 1. a mod_request.dsp project file is attached it requires these manual steps: mod_request.dsp should be added to the Apache.dsw workspace buildbin should depend on mod_request mod_request depends on libapr, libaprutil, libhttpd add mod_request.h to "headers" in libhttpd with a custom-build step: type .\modules\filters\mod_request.h > .\include\mod_request.h 2. a Makefile.win patch is attached in the next comment.
Created attachment 21951 [details] Windows Makefile.win patch (trunk)
Tom, please also raise this on the dev list and feel free to commit your windows specific patches.
(In reply to comment #3) > Tom, please also raise this on the dev list and feel free to commit your > windows specific patches. > Thanks Ruediger, but I don't have commit access yet. I expect it takes a little while to get processed. re: "raise this on the dev list" - sure, if you think it's worthwhile. I presumed this was just routine "tidying up" after r647263 ... r654952 which were pretty well discussed.
Fixed along with a host of modules, thanks for the report. Please do review your build success on trunk and report back to dev@ if there are any remaining issues beyond mod_serf, which I didn't get to as a matter of it's really crufty looking comments.