Bug 45123 - Token operand class not being copied by SharedFormulaRecord.convertSharedFormulas()
Summary: Token operand class not being copied by SharedFormulaRecord.convertSharedForm...
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: 3.0-dev
Hardware: PC Windows XP
: P2 normal with 4 votes (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2008-06-03 10:02 UTC by Josh Micich
Modified: 2008-06-04 20:14 UTC (History)
2 users (show)

Draft of SharedFormulaRecord (.java and .class) (7.03 KB, application/zip)
2008-06-03 12:54 UTC, Josh Micich

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Micich 2008-06-03 10:02:01 UTC
Originally reported as a re-open of bug 42541.

If the example file (https://issues.apache.org/bugzilla/attachment.cgi?id=22062) is read and re-written by POI, the formulas in Sheet1!C6:C21 all display as '#VALUE!' in Excel.

The formulas contain tokens with operand class 'array'.  The code in SharedFormulaRecord.convertSharedFormulas() does not propagate the operand class correctly.
Comment 1 Josh Micich 2008-06-03 10:06:48 UTC
The following patch fixes this bug:
Index: SharedFormulaRecord.java
--- SharedFormulaRecord.java    (revision 661934)
+++ SharedFormulaRecord.java    (working copy)
@@ -201,6 +201,10 @@
         if (ptgs != null)
           for (int k = 0; k < ptgs.size(); k++) {
             Ptg ptg = (Ptg) ptgs.get(k);
+            byte originalOperandClass = -1;
+            if (!ptg.isBaseToken()) {
+                originalOperandClass = ptg.getPtgClass();
+            }
             if (ptg instanceof RefNPtg) {
               RefNPtg refNPtg = (RefNPtg)ptg;
               ptg = new ReferencePtg(fixupRelativeRow(formulaRow,refNPtg.getRow(),refNPtg.isRowRelative()),
@@ -249,7 +253,11 @@
-            }
+            }
+            if (!ptg.isBaseToken()) {
+                ptg.setClass(originalOperandClass);
+            }
         return newPtgStack;

A junit also needs to be added.
Comment 2 vijay 2008-06-03 11:48:05 UTC
     Could you send me the revised SharedFormulaRecord.java file or give me the location to get that file. I want to test it out.

Comment 3 Josh Micich 2008-06-03 12:54:27 UTC
Created attachment 22065 [details]
Draft of SharedFormulaRecord (.java and .class)

base version is r652934
Comment 4 Josh Micich 2008-06-03 13:00:10 UTC
(In reply to comment #3)
> Created an attachment (id=22065) [details]

This file can be patched into the svn trunk (I think it depends on bug 45060, which is very recent). 

You can get the latest from subversion with the following command:
svn co https://svn.apache.org/repos/asf/poi/trunk

Comment 5 Josh Micich 2008-06-04 20:14:26 UTC
(In reply to comment #1)
> The following patch fixes this bug ...

Applied patch in svn r663436

junit test added as well.