Bug 45814 - [PATCH] Specify RecordType for slide show Handout (4041)
Summary: [PATCH] Specify RecordType for slide show Handout (4041)
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSLF (show other bugs)
Version: unspecified
Hardware: PC Mac OS X 10.4
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-15 15:27 UTC by Don Boulia
Modified: 2008-09-18 03:59 UTC (History)
0 users


Attachments
Patch for RecordTypes.java (902 bytes, patch)
2008-09-15 15:27 UTC, Don Boulia 		Details | Diff
Test case file (3.36 KB, text/plain)
2008-09-15 15:28 UTC, Don Boulia 		Details
input test case powerpoint file (130.50 KB, application/vnd.ms-powerpoint)
2008-09-15 15:29 UTC, Don Boulia 		Details
Image file (used in test case) (17.01 KB, image/jpeg)
2008-09-15 15:30 UTC, Don Boulia 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Boulia 2008-09-15 15:27:45 UTC 
Created attachment 22580 [details]
Patch for RecordTypes.java

The Handout type is currently specified as null in RecordTypes.java.  When a slideshow that has the handout specified is modified, dumping the resulting file with SlideShowRecordDumper reports an invalid offset in the Handout record.  Changing the Handout record to a type of DummyPositionSensitiveRecordWithChildren resolves the issue.  Test case, supporting files and patch attached.
Comment 1 Don Boulia 2008-09-15 15:28:46 UTC 
Created attachment 22581 [details]
Test case file
Comment 2 Don Boulia 2008-09-15 15:29:26 UTC 
Created attachment 22582 [details]
input test case powerpoint file
Comment 3 Don Boulia 2008-09-15 15:30:03 UTC 
Created attachment 22583 [details]
Image file (used in test case)
Comment 4 Yegor Kozlov 2008-09-18 03:59:05 UTC 
Fixed in r696627.

Yegor