Bug 48044 - [PATCH] Implementation of COUNTBLANK()
[PATCH] Implementation of COUNTBLANK()
Product: POI
Classification: Unclassified
Component: HSSF
All All
: P2 normal (vote)
: ---
Assigned To: POI Developers List
Depends on:
  Show dependency tree
Reported: 2009-10-23 17:02 UTC by Mads Mohr Christensen
Modified: 2009-10-23 17:57 UTC (History)
0 users

Implementation and test case for COUNTBLANK() (6.53 KB, patch)
2009-10-23 17:03 UTC, Mads Mohr Christensen
Details | Diff
Test data (6.50 KB, application/octet-stream)
2009-10-23 17:05 UTC, Mads Mohr Christensen

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Mohr Christensen 2009-10-23 17:02:46 UTC
Attached patch are the implementation of the COUNTBLANK() function. Function was mentioned in the test case but actually not implemented. Also included in the patch are the test case.
Comment 1 Mads Mohr Christensen 2009-10-23 17:03:42 UTC
Created attachment 24412 [details]
Implementation and test case for COUNTBLANK()
Comment 2 Mads Mohr Christensen 2009-10-23 17:05:03 UTC
Created attachment 24413 [details]
Test data
Comment 3 Josh Micich 2009-10-23 17:57:07 UTC
Applied with slight simplifications in svn r829293

Thanks for adding unit tests.

BTW - I agree with your TODO comment. Another concern is how Excel behaves when other application write files with incorrect arg counts, but from what I can tell Excel(2007) reports an error "File error: data may have been lost."  It seems like it is OK for POI to crash on this condition.  We'll probably fix these globally at some point.