Bug 49337 - [PATCH] method disableClipping should be in PSGraphics2D class, not in AbstractPSDocumentGraphics2D
Summary: [PATCH] method disableClipping should be in PSGraphics2D class, not in Abstra...
Status: RESOLVED FIXED
Alias: None
Product: XMLGraphicsCommons - Now in Jira
Classification: Unclassified
Component: java2D (show other bugs)
Version: Trunk
Hardware: All All
: P2 trivial (vote)
Target Milestone: --
Assignee: XML Graphics Project Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-25 06:30 UTC by Julien Aymé
Modified: 2010-05-30 11:11 UTC (History)
0 users


Attachments
The proposed patch (1.16 KB, application/octet-stream)
2010-05-25 06:30 UTC, Julien Aymé 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Aymé 2010-05-25 06:30:58 UTC 
Created attachment 25479 [details]
The proposed patch

The field clippingDisabled is defined in PSGraphics2D class, with a default value to false.
The setter for this field is defined in the AbstractPSDocumentGraphics2D sub-class.

I think that the setter should be defined in PSGraphics2D class, so that the setter stands next to the field.

The patch is trivial: remove the method disableClipping from AbstractPSDocumentGraphics2D and put it back into PSGraphics2D.
Comment 1 Jeremias Maerki 2010-05-30 11:11:50 UTC 
Makes sense. Patch applied with rev 949527 (http://svn.apache.org/viewvc?rev=949527&view=rev). Thanks for the patch.