Created attachment 27181 [details]
Proposed patch

Hi,

here is a patch that makes a few cleans up.

modified files are :

  - server/util.c : use apr_pstrmemdup instead of apr_pstrdup in order to avoid a call to strlen. Compute the length first and use it twice.

  - server/vhost.c : reorder code to do as above.
  - modules/proxy/proxy_util.c : same
  - modules/aaa/mod_authnz_ldap.c : more or less the same
  - modules/mappers/mod_rewrite.c : same
  - modules/dav/main/mod_dav.c : same
  - modules/dav/fs/repos.c : more or less the same

  - modules/proxy/mod_serf.c : use strcmp instead of strcasecmp when possible
                             : avoid a call to apr_pstrndup <-- PLEASE DOUBLE CHECK THIS ONE TO SEE IF THERE IS NO SIDE EFFECT

  - modules/cluster/mod_heartmonitor.c : use 'ap_rputs' instead of 'ap_rprintf'


Before apply the patch, please at least double check 'modules/proxy/mod_serf.c' to make sure that there is no side effect. The other ones should be ok as-is.

Hope this helps.