Bug 52258 - CodePageString null check triggering for non codepage data
CodePageString null check triggering for non codepage data
Product: POI
Classification: Unclassified
Component: HPSF
PC Linux
: P2 normal (vote)
: ---
Assigned To: POI Developers List
Depends on:
  Show dependency tree
Reported: 2011-11-28 17:36 UTC by Nick Burch
Modified: 2016-01-03 21:23 UTC (History)
0 users


Note You need to log in before you can comment on or make changes to this bug.
Description Nick Burch 2011-11-28 17:36:01 UTC
There seems to be something up with the new HPSF properties parsing and CodePageString. 

The result is that for files such as "TestVisioWithCodepage.vsd" (taken from the Tika test suite, and created with Visio), HPSF is deciding that at least one apparently non codepage property is one

What then happens is that the string "Page-1\0c" is parsed through the null termination check in CodePageString, and blows up
Comment 1 Dominik Stadler 2016-01-03 21:23:49 UTC
Added a unit test in r1722755 which tries to reproduce this, it seems to work now, thus closing this old bug as WORKSFORME for now.