Bug 55031 - Update MANIFEST.MF for OSGi headers
Update MANIFEST.MF for OSGi headers
Status: RESOLVED FIXED
Product: Tomcat Modules
Classification: Unclassified
Component: jdbc-pool
unspecified
All All
: P2 normal (vote)
: ---
Assigned To: Tomcat Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-05-30 13:40 UTC by Martin Lichtin
Modified: 2013-06-28 13:26 UTC (History)
0 users



Attachments
Updated Import-/Export-Package headers (created using bnd) (1.06 KB, text/plain)
2013-05-30 13:40 UTC, Martin Lichtin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lichtin 2013-05-30 13:40:15 UTC
Created attachment 30344 [details]
Updated Import-/Export-Package headers (created using bnd)

The jdbc-pool/resources/MANIFEST.MF should be updated with
correct Export-/Import-Package headers.
Comment 1 Violeta Georgieva 2013-06-28 06:43:50 UTC
Hi,

In the patch you specify in the Export-Package header:

org.apache.tomcat.jdbc.pool.interceptor;uses:="org.apache.tomcat.jdbc.pool,org.apache.juli.logging,javax.management.openmbean,org.apache.tomcat.jdbc.pool.jmx,javax.management";version="@VERSION@"

I cannot find any of the classes in package org.apache.tomcat.jdbc.pool.interceptor to use package org.apache.tomcat.jdbc.pool.jmx.

Can you please check that?
Against which sources did you run bnd tool? I'm checking tomcat 7 trunk.

Regards
Violeta
Comment 2 Martin Lichtin 2013-06-28 10:11:39 UTC
I took the 7.0.40 sources artifact, as far as I can remember.

However, when getting the sources from trunk and using the Felix bundle plugin,
the same import/export headers are generated.

I don't understand why Bnd (http://www.aqute.biz/Bnd/Bnd) thinks 
the "interceptor" package is using classes from "jmx", but then again, 
I have never questioned Bnd's outcome either, because the creation 
of import/export headers is normally done under the hood.
 
Please feel free to remove "org.apache.tomcat.jdbc.pool.jmx" from the 
uses: clause of org.apache.tomcat.jdbc.pool.interceptor.

The rest, as far as I can see, is adequate.
Comment 3 Violeta Georgieva 2013-06-28 13:26:20 UTC
Fixed in trunk and 7.0.x and will be included in 7.0.42 onwards.