Bug 55347 - [PATCH] Integrate XSSFTextBox with XSSFExcelExtractor, XSSFReader and XSSFEventBasedExcelExtractor
Summary: [PATCH] Integrate XSSFTextBox with XSSFExcelExtractor, XSSFReader and XSSFEve...
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: 3.10-dev
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-02 14:43 UTC by Tim Allison
Modified: 2013-08-08 14:04 UTC (History)
0 users


Attachments
Patch, initial draft (12.50 KB, text/plain)
2013-08-02 14:43 UTC, Tim Allison 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Allison 2013-08-02 14:43:37 UTC 
Created attachment 30663 [details]
Patch, initial draft

Follow on work to Darren Robert's patch of XSSFTextBox: https://issues.apache.org/bugzilla/show_bug.cgi?id=55292

This patch integrates those updates into XSSFExcelExtractor and XSSFEventBasedExcelExtractor. 

I'm posting the patch for review.  Two items that I'm not sure about:

1) I'm not actually streaming the textbox extraction in XSSFReader.  I followed the model of headers and footers and used the regular XSSF-bean-based objects.

2) I had to change the XSSFDrawing() constructors to public.

Would appreciate any feedback on those issues or on the patch before I commit.

Thank you.
Comment 1 Darren Roberts 2013-08-05 10:13:02 UTC 
I've tried the patch out and it compiled for me, passed the unit tests and when used with another test application successfully resolves this long standing bug:

https://issues.apache.org/bugzilla/show_bug.cgi?id=45551
Comment 2 Tim Allison 2013-08-08 14:04:41 UTC 
Committed r1511789.