Bug 55439 - 'catalina.sh stop -force' doesn't account for empty pid file
Summary: 'catalina.sh stop -force' doesn't account for empty pid file
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Packaging (show other bugs)
Version: 8.0.x-trunk
Hardware: All Linux
: P2 minor (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 21:40 UTC by David Minor
Modified: 2013-08-20 19:12 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Minor 2013-08-16 21:40:18 UTC 
When CATALINA_PID is provided to 'catalina.sh stop -force', but the script doesn't have permission to remove the file, the script instead clears the CATALINA_PID file's contents. The subsequent code for '-force' doesn't account for this and attempts to call kill an empty PID argument, leading to spurious error messages.
Comment 1 Mark Thomas 2013-08-20 19:12:51 UTC 
Thanks for the report. This has been fixed in trunk and will be included in 8.0.0-RC2 onwards and has also been fixed in 7.0.x for 7.0.43 onwards.

I also took the opportunity to fix a related issue if a forced stop is required and the pid file can only be cleared rather than removed.