Bug 55746 - Add documentation for AllRolesMode for CombinedRealm
Summary: Add documentation for AllRolesMode for CombinedRealm
Alias: None
Product: Tomcat 6
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: All All
: P2 minor (vote)
Target Milestone: default
Assignee: Tomcat Developers Mailing List
Depends on:
Reported: 2013-11-06 06:59 UTC by Cédric Couralet
Modified: 2013-11-09 19:36 UTC (History)
0 users

Patch for Tomcat6 (2.84 KB, text/plain)
2013-11-06 06:59 UTC, Cédric Couralet

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Couralet 2013-11-06 06:59:41 UTC
Created attachment 31012 [details]
Patch for Tomcat6

The attribute "allRolesMode" is not listed in the attributes for the CombinedRealm or LockOutRealm. I have been bitten by it as I thought it was then sufficient to put it in each of the nested Realms. 
It appears that the check for HasResourcePermission is done on the context.getRealm() which is not passed in the nested Realms in the case of CombinedRealm.

I think just adding it to the documentation should be sufficient.

I only have a working copy of Tomcat 6 handy, so the patch is done to that version.
Comment 1 Mark Thomas 2013-11-09 19:36:18 UTC
Thanks for the patch. It has been applied to trunk, 7.0.x and 6.0.x and will be included in 8.0.0-RC6, 7.0.48 and 6.0.38 onwards.