Bug 57364 - Options > Look And Feel does not update all windows LAF
Summary: Options > Look And Feel does not update all windows LAF
Status: RESOLVED WORKSFORME
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.12
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2014-12-18 13:24 UTC by UbikLoadPack support
Modified: 2019-08-09 02:51 UTC (History)
1 user (show)


Attachments
Patch fixing issue (910 bytes, patch)
2014-12-18 13:27 UTC, UbikLoadPack support 		Details | Diff
Patch fixing this issue (1.67 KB, patch)
2014-12-18 13:29 UTC, UbikLoadPack support 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description UbikLoadPack support 2014-12-18 13:24:36 UTC 
When using menu "Options > Look And Feel", Changing LAF only impacts main frame.
If you look at those dialogs, they are not impacted:
- Search Tree
- Function Helper Dialog
- Templates
...

This leads sometimes to NPE , for example in Function Helper Dialog
Comment 1 UbikLoadPack support 2014-12-18 13:27:33 UTC 
Created attachment 32301 [details]
Patch fixing issue
Comment 2 UbikLoadPack support 2014-12-18 13:29:18 UTC 
Created attachment 32302 [details]
Patch fixing this issue
Comment 3 Philippe Mouawad 2014-12-19 21:33:08 UTC 
Date: Fri Dec 19 21:32:38 2014
New Revision: 1646879

URL: http://svn.apache.org/r1646879
Log:
Bug 57364 - Options > Look And Feel does not update all windows LAF
Bugzilla Id: 57364

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/LookAndFeelCommand.java
    jmeter/trunk/xdocs/changes.xml
Comment 4 karthiga.n 2019-07-17 04:50:32 UTC 
options -> Look and Feel --> Choose a theme --> CLick "No: in the pop-up page

Observation :
the page remains with the chosen theme and then on no proper UI is available to work on
Comment 5 Philippe Mouawad 2019-07-17 05:56:09 UTC 
That’s the expected behavior.
The popup informs you it’s better to restart, you didn’t which is why you get the « buggy » behavior.

1 question for the team, should we let user decide on this ?
or just restart.
Comment 6 Felix Schumacher 2019-07-17 18:48:44 UTC 
I would not force the user to restart any harder. But maybe we would want to change the behaviour of the UI to change LAF on the next startup, only.  I.e. set the new LAF in the config files, but not directly in the GUI.
Comment 7 Philippe Mouawad 2019-07-18 07:19:16 UTC 
Hi Felix,
I don't know if this issue is worth investing time on it. I thought today's  behaviour was clear enough, but it seems it's not.

Regarding your proposal, if we only change LAF after restart, then maybe we need to inform user in the popup.
Comment 8 Felix Schumacher 2019-07-18 10:43:45 UTC 
I would not change anything at the moment, as we are telling the user to restart. If they choose not to, it is their responsibility.

If we would change the behaviour, we would have to change the text of the popup. That should be clear.
Comment 9 The ASF infrastructure team 2022-09-24 20:37:58 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3502