Created attachment 32447 [details] Module Controller with JTree I found very hard selecting controllers from a provided combo box in Module Controller UI. Especially for larger test plans. Please consider rewritten UI with JTree instead of JComboBox, It is available in an attachement (ModuleControllerGui.java) For that implementation, selecting of a module is done by selecting element of a tree. Element name is changed to a referenced module name with "[MC]" prefix Expand button also is slightly changed, after pushing it, test plan is expanded and focus is set to referenced module.
Hi, Thanks for contribution. I find it clearly much better than current behaviour. Few notes: - I don't think you should change element name to [MC] - Methods should have minimum javadocs Thanks. Regards
Created attachment 32483 [details] Improved verstion of ModuleControllerGui - removed [MC] prefix - added javadoc and some comments
Date: Tue Feb 17 21:59:29 2015 New Revision: 1660514 URL: http://svn.apache.org/r1660514 Log: Bug 57561 - Module controller UI : Replace combobox by tree Bugzilla Id: 57561 Modified: jmeter/trunk/src/components/org/apache/jmeter/control/gui/ModuleControllerGui.java jmeter/trunk/xdocs/changes.xml
Hi, Thanks a lot for your contribution and update. I commited it with few changes: - Removed the code that changes element name depending on selection as it might be annoying when you don't want this and it's a new behaviour - Made internal class static - Used more meaningful names for some fields Your tests on nightly builds are welcome. Regards
Changes are ok to me except: - Removed the code that changes element name depending on selection as it might be annoying when you don't want this and it's a new behaviour In my personal opinion it could be configured as a property in jmeter.properties. By default name is not changed, but it is possible to configure automatic change in jmeter.properties What do you think about that? I use JMeter a lot and Module Controller also, and I found it very convinient that name of Module Controller is automatically changed to a referenced module. When the name was not automatically changed I had a lot of elements named Module Controller and there was quite a lot of write/copy/paste/etc. work to name module controller elements (as almost always I changed it to a referenced element name) Many thanks
Hi, What about instead of a new global property , add a checkbox that would be component property in GUI to enable or disable this behaviour ? Regards @ubikloadpack
Hi, Ok for me, but still I would add global property to define if this checkbox is enabled/disabled by default Regards, Maciej Franek
(In reply to maciej.franek from comment #7) > Hi, > > Ok for me, but still I would add global property to define if this checkbox > is enabled/disabled by default > > Regards, > Maciej Franek I suggest you discuss this on dev mailing list so that all team developers give their opinion to see if your patch would be accepted.
After discussing on dev mailing list I`ve prepared new version of Module Controller UI that contains two new fields: 1. Checkbox - enables/disables automatic name change. By default it is disabled. Default value is configurable in jmeter.properties 2. Text field for prefix automatic naming. By default it is empty. Also configurable in jmeter.properties I`m attaching patch containing changes. Many thanks, Maciej Franek
Created attachment 32712 [details] Module controller with automatic name change
Bug fixed in 2.13. A new Bug 58780 was created as followup of automatic name change.
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3530