Bug 57577 - HttpSampler : Retrieve All Embedded Resources, add property "httpsampler.embedded_resources_use_md5" to only compute md5 and not keep response data
Summary: HttpSampler : Retrieve All Embedded Resources, add property "httpsampler.embe...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 2.12
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-12 21:58 UTC by Philippe Mouawad
Modified: 2016-02-17 22:59 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2015-02-12 21:58:43 UTC
Currently when you check Retrieve All Embedded Resources, JMeter will create a Parent SampleResult and Child SampleResults for downloaded resources.
These children will occupy a lot of memory and in most case you are only interested to know if download occured (response code) and that size was > 0.

So I suggest that by default, we either compute a Hash (but this can be cpu intensive) or only size.

This way we would save a lot of memory and make those kind of tests perform much better and  much easier to configure.
Comment 1 Sebb 2015-02-12 23:13:19 UTC
We cannot change the default; this will break existing tests.
Comment 2 Philippe Mouawad 2015-02-15 19:50:55 UTC
(In reply to Sebb from comment #1)
> We cannot change the default; this will break existing tests.

We can provided we add a property to switch back. 
We made some massive tests from cloud using this option and although possible it has some performance impacts that need to be handled making it not so easy.

This option would ease this drastically.
Comment 3 Sebb 2015-02-15 22:16:54 UTC
(In reply to Philippe Mouawad from comment #2)
> (In reply to Sebb from comment #1)
> > We cannot change the default; this will break existing tests.
> 
> We can provided we add a property to switch back.

No, I think users need to take specific action to enable this change.

> We made some massive tests from cloud using this option and although
> possible it has some performance impacts that need to be handled making it
> not so easy.
> 
> This option would ease this drastically.

That does not mean every test should get this option by default.
Comment 4 benoit.wiart 2016-02-17 22:14:21 UTC
added a new parameter httpsampler.ignore_embedded_resources_data to do that
default to false (the current behaviour)

PR https://github.com/apache/jmeter/pull/127
Comment 5 Philippe Mouawad 2016-02-17 22:42:00 UTC
Date: Wed Feb 17 22:41:37 2016
New Revision: 1730962

URL: http://svn.apache.org/viewvc?rev=1730962&view=rev
Log:
Bug 57577 - HttpSampler : Retrieve All Embedded Resources should only compute size or hash by default
#resolve #127
Bugzilla Id: 57577

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
    jmeter/trunk/xdocs/changes.xml