Bug 57899 - Refactor XWPFRun and XWPFParagraph so the PPr/RPr logic can be shared with the default styles code
Summary: Refactor XWPFRun and XWPFParagraph so the PPr/RPr logic can be shared with th...
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: XWPF (show other bugs)
Version: 3.12-dev
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-07 13:28 UTC by Nick Burch
Modified: 2016-03-13 20:11 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Burch 2015-05-07 13:28:38 UTC 
As of r1678193, XWPFStyles now exposes the default paragraph and run style information via new classes XWPFDefaultRunStyle and XWPFDefaultParagraphStyle

However, these classes don't have much logic on them. Most of what they need can be found on XWPFRun and XWPFParagraph, and both sets work with the same objects, RPr / PPr

Therefore, the common RPr logic should be refactored out of XWPFRun and put somewhere so it can be shared with XWPFDefaultRunStyle. Likewise, the same should be done for PPr logic in XWPFParagraph for XWPFDefaultParagraphStyle