Bug 57963 - XWPFDocument should not depend on scratchpad-jar
Summary: XWPFDocument should not depend on scratchpad-jar
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XWPF (show other bugs)
Version: 3.12-FINAL
Hardware: PC Linux
: P1 blocker (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks: 57957
  Show dependency tree
 
Reported: 2015-05-28 05:46 UTC by Dominik Stadler
Modified: 2015-06-16 05:51 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Stadler 2015-05-28 05:46:29 UTC
Seems we introduced a dependency to class Paragraph via commit "Stub a common WP paragraph class, needs uncommenting as XWPF implements/emulates", r1657712.

We should move this class to the main jar.

When this is done we should also adjust the text at http://poi.apache.org/document/index.html back to state that scratchpad.jar should not be necessary for ooxml based XWPFDocument.
Comment 1 Nick Burch 2015-05-28 11:18:50 UTC
I think that as of r1682212, having moved the SL and WP interfaces to core, the only part of OOXML which needs scratchpad is the ExtractorFactory

If someone else could verify, we can then put the documentation back, and note that dependency reason
Comment 2 Dominik Stadler 2015-06-16 05:51:46 UTC
I have now added additional steps to the "post-package" verification build at "src\integrationtest\build.xml" which uses the resulting jar-files from the assemble-step and ensures that most of the examples can be built without having scratchpad.jar in the classpath. 

The following list of files is excluded currently as it uses HWPF or other things from scratchpad.jar:

    org/apache/poi/hslf/**,org/apache/poi/hsmf/**,**/EmbeddedObjects.java,**/EmeddedObjects.java,**/Word2Forrest.java

I also updated the documentation page, so this is fixed as far as I see.