Bug 58220 - XSSFFont getFontHeight javadoc says "in points" but should say "in EMUs"
Summary: XSSFFont getFontHeight javadoc says "in points" but should say "in EMUs"
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: unspecified
Hardware: All All
: P2 trivial (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 19:44 UTC by petteyg359
Modified: 2015-08-12 14:14 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description petteyg359 2015-08-06 19:44:40 UTC 
The Javadoc should specify the right unit that the method actually returns.
Comment 1 Nick Burch 2015-08-12 13:05:56 UTC 
I don't think they are EMUs though, are they?

From a quick check, the return looks to be in 20th points, just as with HSSF, and as described at https://poi.apache.org/apidocs/org/apache/poi/ss/usermodel/Font.html#getFontHeight%28%29

I'd propose replacing the XSSFFont javadoc with the Font or HSSFFont one, would that solve the issue for you?
Comment 2 petteyg359 2015-08-12 13:59:13 UTC 
That's probably best. Looking at the source, getFontHeightInPoints has nothing but "@see #getFontHeight" which is rather inadequate documentation. HSSFFont documentation actually exists :)
Comment 3 Nick Burch 2015-08-12 14:14:54 UTC 
Fixed in r1695528, and site republished with the updates in, thanks for your advice!