Bug 58473 - iconv unnecessary includes unistd.h on Windows
Summary: iconv unnecessary includes unistd.h on Windows
Status: NEW
Alias: None
Product: APR
Classification: Unclassified
Component: APR-iconv (show other bugs)
Version: HEAD
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache Portable Runtime bugs mailinglist
Depends on:
Reported: 2015-10-02 16:59 UTC by Thorsten Schöning
Modified: 2015-10-02 16:59 UTC (History)
0 users


Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Schöning 2015-10-02 16:59:42 UTC
iconv.c includes unistd.h, which is not available on Windows, but not needed at all as well, because iconv uses APR and its apr_getopt itself. The comment around unistd.h states that it was only needed for getopt. My current workaround, because I don't want to patch the source, is to provide an empty unistd.h file in the search paths for includes.

So I propose to simply remove that line entirely. Thanks!