Bug 58644 - Deprecate Sheet.setZoom(numerator, denominator), replace with Sheet.setZoom(scale)
Summary: Deprecate Sheet.setZoom(numerator, denominator), replace with Sheet.setZoom(s...
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: 3.14-dev
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-24 07:00 UTC by Javen O'Neal
Modified: 2015-11-24 08:27 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2015-11-24 07:00:46 UTC 
Sheet.setZoom(numerator, denominator) leaks too much information about how HSSFSheets save zoom level. This zoom function carried over into the XSSFSheet world, where it's inconvenient and clumsy.

The spreadsheet API should either use setZoom(int percent) or setZoom(double ratio). A percent (multiply zoom ratio by 100) is already implemented in XSSFSheet, so this seems like the natural pick.
Comment 1 Javen O'Neal 2015-11-24 08:27:07 UTC 
Implemented in r1716048 and r1716053, updated docs in r1716049.