Bug 58870 - TableEditor: minimum size is too small
Summary: TableEditor: minimum size is too small
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-15 11:08 UTC by Vincent HERILIER
Modified: 2016-02-18 12:54 UTC (History)
1 user (show)



Attachments
limits the minimun size of TableEditor UI widget to show header row and at least 2 data rows (710 bytes, patch)
2016-01-27 09:01 UTC, Vincent HERILIER
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent HERILIER 2016-01-15 11:08:01 UTC
As a JMeter windows is reduced in height or has a too small height and if there's a TableEditor widget in the shown element, the widget could be reduced in heigth to the height of the header row only.
It could be useful to limit its minimal height
Comment 1 Vincent HERILIER 2016-01-15 11:12:22 UTC
Setting the minimum size in the makePanel method insures not reducing too much the widget and allows to see if there's at least a row inside

By my side I'm using "scroller.setMinimumSize(new Dimension(100, 70));" to set it

...
private JComponent makePanel()
    {
        JPanel p = new JPanel(new BorderLayout());
        JScrollPane scroller = new JScrollPane(table);
        scroller.setMinimumSize(new Dimension(100, 70));
        scroller.setPreferredSize(scroller.getMinimumSize());
        p.add(scroller,BorderLayout.CENTER);
        JPanel south = new JPanel();
...
Comment 2 Vincent HERILIER 2016-01-27 09:01:42 UTC
Created attachment 33495 [details]
limits the minimun size of TableEditor UI widget to show header row and at least 2 data rows

patch that fixes the minimum size to the TableEditor UI widget when the windows is size reduced, the widget will no more be reduced until its header height. At least 2 rows will be shown
Comment 3 Vincent HERILIER 2016-02-18 10:45:25 UTC
made a PR#128: https://github.com/apache/jmeter/pull/128
Comment 4 Philippe Mouawad 2016-02-18 12:52:50 UTC
Date: Thu Feb 18 12:51:28 2016
New Revision: 1731061

URL: http://svn.apache.org/viewvc?rev=1731061&view=rev
Log:
Bug 58870 - TableEditor: minimum size is too small
#resolve #128
Bugzilla Id: 58870

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TableEditor.java
    jmeter/trunk/xdocs/changes.xml
Comment 5 Vincent HERILIER 2016-02-18 12:54:42 UTC
Thanks a lot