Bug 59351 - Improve log/error/message for IncludeController
Summary: Improve log/error/message for IncludeController
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.0
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-18 21:28 UTC by Antonio Gomes Rodrigues
Modified: 2016-06-10 21:45 UTC (History)
2 users (show)


Attachments
Current error message (6.00 KB, image/png)
2016-04-18 21:28 UTC, Antonio Gomes Rodrigues 		Details
My proposal (5.72 KB, image/png)
2016-04-18 21:29 UTC, Antonio Gomes Rodrigues 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes Rodrigues 2016-04-18 21:28:04 UTC 
Created attachment 33775 [details]
Current error message

Hi,


When JMeter try to load a file which don't exist in InludeController we have this log

2016/04/18 22:22:12 INFO  - jmeter.services.FileServer: Set new base='C:\Util\0_JMX' 
2016/04/18 22:22:13 INFO  - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 INFO  - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 INFO  - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 INFO  - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 INFO  - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 INFO  - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\  C:\Util\0_JMX\IncludeSRCFragment.jmx 
2016/04/18 22:34:12 WARN  - jmeter.control.IncludeController: Unexpected error java.io.IOException: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\  C:\Util\0_JMX\IncludeSRCFragment.jmx and C:\Util\0_JMX\  C:\Util\0_JMX\IncludeSRCFragment.jmx
	at org.apache.jmeter.control.IncludeController.loadIncludedElements(IncludeController.java:135)
	at org.apache.jmeter.control.IncludeController.resolveReplacementSubTree(IncludeController.java:111)
	at org.apache.jmeter.control.IncludeController.clone(IncludeController.java:64)
	at org.apache.jmeter.gui.action.CheckDirty.addNode(CheckDirty.java:162)


and a popup box with useless message to user (see attached screenshot)

I propose to have a more usefull log and error message.

Ant to check that the file can be read

Antonio
Comment 1 Antonio Gomes Rodrigues 2016-04-18 21:29:24 UTC 
Created attachment 33776 [details]
My proposal
Comment 2 Antonio Gomes Rodrigues 2016-04-18 21:31:26 UTC 
PR 202 commited

Antonio
Comment 3 Philippe Mouawad 2016-06-10 21:45:51 UTC 
Date: Fri Jun 10 21:43:59 2016
New Revision: 1747805

URL: http://svn.apache.org/viewvc?rev=1747805&view=rev
Log:
Bug 59351 - Improve log/error/message for IncludeController
#resolve #202
Bugzilla Id: 59351

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/control/IncludeController.java
    jmeter/trunk/xdocs/changes.xml
Comment 4 The ASF infrastructure team 2022-09-24 20:38:04 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3954