Bug 59923 - The default value of validationInterval attribute is too long.
Summary: The default value of validationInterval attribute is too long.
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Modules
Classification: Unclassified
Component: jdbc-pool (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-02 07:26 UTC by Tatsuya Bessho
Modified: 2016-08-03 08:52 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuya Bessho 2016-08-02 07:26:01 UTC
The validationInterval attribute is 30 seconds by default.
In case of DB reboots, trigger some problems.
For example, the following events will be considered.

1. The connection is validated.
2. DB reboots.
3. getConnection() within 30 seconds.
4. The connection isn't validated by testOnBorrow.
5. Get the invalid connection.

And worse, the default value of fairQueue is true.
As a result, invalid connection is continued to use.

Therefore, I think the default value should be more short or "0(disable)".
Comment 1 Keiichi Fujino 2016-08-02 07:35:14 UTC
That's for sure.

I plan to reduce the default value of validationInterval.
Probably about 3000 millseconds(that is 10% value existing).
I am going to commit this tomorrow if there is no objections.
Comment 2 Keiichi Fujino 2016-08-03 08:52:56 UTC
The fix will be in :
- 9.0.x for 9.0.0.M10 onwards
- 8.5.x for 8.5.5 onwards
- 8.0.x for 8.0.37 onwards
- 7.0.x for 7.0.71 onwards