Bug 59979 - [patch] Add log message when ap_save_brigade fails
Summary: [patch] Add log message when ap_save_brigade fails
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: All (show other bugs)
Version: 2.5-HEAD
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-11 15:16 UTC by jiazhouyang
Modified: 2016-08-11 15:58 UTC (History)
0 users


Attachments
Add log message when ap_save_brigade fails (744 bytes, patch)
2016-08-11 15:16 UTC, jiazhouyang 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jiazhouyang 2016-08-11 15:16:56 UTC 
Created attachment 34125 [details]
Add log message when ap_save_brigade fails

Function ap_save_brigade may fail. The majority of calls have checked the return value and printed log message like the following code snippet, while the others have not. Those unchecked ones probably need logs too (see attachment).

/* httpd-2.4.10/modules/proxy/mod_proxy_http.c:826:18 */
        status = ap_save_brigade(NULL, &input_brigade, &temp_brigade, p);
        if (status != APR_SUCCESS) {
            ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(01096)
                          "processing prefetched request body failed"
                          " to %pI (%s) from %s (%s)",
                          p_conn->addr, p_conn->hostname ? p_conn->hostname: "",
                          c->client_ip, c->remote_host ? c->remote_host: "");
            return HTTP_INTERNAL_SERVER_ERROR;
        }