Bug 60393 - Inconsistent parameter naming between Realm interface and implementations
Summary: Inconsistent parameter naming between Realm interface and implementations
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.5.x-trunk
Hardware: All All
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-20 19:06 UTC by Michael Osipov
Modified: 2016-11-21 12:49 UTC (History)
0 users



Attachments
Fix inconsistency between interface and implemenations (2.73 KB, patch)
2016-11-20 19:07 UTC, Michael Osipov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2016-11-20 19:06:11 UTC
the method #authenticate(GSSContext, boolean) has the boolean variable named "storeCreds", some implementations have "storeCred". It spreads inconsistently. Given that the GSSCredential is singular, the boolean variable should be too.

Attached is a patch to fix this inconsistency.
Comment 1 Michael Osipov 2016-11-20 19:07:10 UTC
Created attachment 34464 [details]
Fix inconsistency between interface and implemenations
Comment 2 Mark Thomas 2016-11-21 11:49:09 UTC
The Javadoc for org.ietf.jgss.GSSContext.getDelegCred() uses the plural. Using the plural is also a smaller change.

Fixed in:
- trunk for 9.0.0.M14 onwards
- 8.5.x for 8.5.9 onwards
- 8.0.x for 8.0.40 onwards
- 7.0.x for 7.0.74 onwards

6.0.x was not affected.
Comment 3 Michael Osipov 2016-11-21 12:49:42 UTC
That's f(In reply to Mark Thomas from comment #2)
> The Javadoc for org.ietf.jgss.GSSContext.getDelegCred() uses the plural.
> Using the plural is also a smaller change.
> 
> Fixed in:
> - trunk for 9.0.0.M14 onwards
> - 8.5.x for 8.5.9 onwards
> - 8.0.x for 8.0.40 onwards
> - 7.0.x for 7.0.74 onwards
> 
> 6.0.x was not affected.

Great, that's fine with me as long it is consistent.