Created attachment 34612 [details] Configuration of httpd When apache is set as forward http proxy, CacheEnable disk http://, should cache all http content and it is not working (CacheQuickHandler is Off). It should be caused by this commit: https://github.com/apache/httpd/commit/cc21a5acc79e1d8522373061dd3c2e91487bdc7b by comparing uri and path in file modules/cache/cache_util.c. Complete configuration attached.
Created attachment 34613 [details] Possible patch We are hiting the same issue with 2.4.25. Attached is patch which seems to resolve the issue (uses the same value as 2.4.23 did).
Thanks. Will review.
Created attachment 34616 [details] Another proposed patch Wouldn't this patch be better? One might still want to cache based on the rewritten URL, and attachment 34613 [details] reverts that (was the purpose of r1756553).
I'm not expert here. I can just confirm that 34616 makes our test case to pass.
Created attachment 34770 [details] Early vs final URIs used by mod_cache Depending on whether mod_cache runs in forward proxy and quick handler modes, or normal handler mode, its base path and query string references/canonicalizations are not computed at the same time (before or after quick_handler and proxy_detect transforms) and thus may differ. This patch defines the cache_use_early_url() helper and use it wherever appropriate for mod_cache to consistently refer to the same entity while serving and/or caching the response, in both early and late cases.
Hey, I can confirm, that following example ([2] subexample, forward proxy): https://github.com/pgajdos/apache-rex/tree/master/mod_proxy-cache fails before and pass after the patch in comment 5 on the top of 2.4.25. Thank you!
Thanks all for the test(s), committed to trunk (r1783842) and proposed for backport to 2.4.x.
fixed in 2.4.25 with a followup in .26