Bug 61055 - RewriteValve proxy support
Summary: RewriteValve proxy support
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 9.0.0.M20
Hardware: All All
: P2 enhancement (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-30 12:55 UTC by romain.manni-bucau
Modified: 2017-05-16 13:28 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description romain.manni-bucau 2017-04-30 12:55:17 UTC
Hi

in rewrite valve there is this comment:

        // FIXME: Proxy not supported, would require proxy capabilities in Tomcat
        /* } else if (flag.startsWith("proxy") || flag.startsWith("P")) {
            rule.setProxy(true);*/

Is it planned to actually implement it? One implementation could rely on some external library addition like httpcomponent for instance. Wdyt?

If not intended maybe throwing an error or warning should replace that commented logic?
Comment 1 Remy Maucherat 2017-04-30 16:23:48 UTC
The documentation for the valve is accurate ("P" is not mentioned).

Writing a proxy is rather big business IMO both for development and even more for maintenance. There's no plan to write one at the moment, unless something is contributed.
Comment 2 Mark Thomas 2017-05-16 13:28:57 UTC
I've updated the comments to make it clear that there are no plans to implement proxy support.

This has been fixed in:
- 9.0.x for 9.0.0.M22 onwards
- 8.5.x for 8.5.16 onwards
- 8.0.x for 8.0.45 onwards