Bug 61145 - Missing @Documented annotation in some javax.annotation classes
Summary: Missing @Documented annotation in some javax.annotation classes
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-02 07:46 UTC by Katya Todorova
Modified: 2017-06-02 09:27 UTC (History)
0 users



Attachments
Patch validated against tomcat tests and the corresponding specification (6.91 KB, patch)
2017-06-02 07:46 UTC, Katya Todorova
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Katya Todorova 2017-06-02 07:46:23 UTC
Created attachment 35026 [details]
Patch validated against tomcat tests and the corresponding specification

According to 
https://docs.oracle.com/javaee/7/api/javax/annotation/package-summary.html and 
https://docs.oracle.com/javaee/7/api/javax/annotation/security/package-summary.html

the following classes should have @Documented annotation:

javax.annotation.Generated
javax.annotation.PostConstruct
javax.annotation.PreDestroy
javax.annotation.Priority
javax.annotation.Resources
javax.annotation.security.DeclareRoles
javax.annotation.security.DenyAll
javax.annotation.security.PermitAll
javax.annotation.security.RolesAllowed
javax.annotation.security.RunAs
Comment 1 Mark Thomas 2017-06-02 09:15:40 UTC
Confirmed.

This also needs back-porting to 8.x and 7.x (less Priority which was introduced in Java EE 7).

Working on this now...
Comment 2 Mark Thomas 2017-06-02 09:27:35 UTC
Thanks for spotting this and thanks for the patch.

This has been fixed in:
- trunk for 9.0.0.M22 onwards
- 8.5.x for 8.5.16 onwards
- 8.0.x for 8.0.45 onwards
- 7.0.x for 7.0.79 onwards