Bug 61160 - Missing reason phrase breaks BitKinex WebDAV client
Summary: Missing reason phrase breaks BitKinex WebDAV client
Status: RESOLVED INVALID
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.5.15
Hardware: PC All
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-06 13:21 UTC by Olivier Jaquemet
Modified: 2017-06-06 15:30 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Jaquemet 2017-06-06 13:21:23 UTC
To reproduce :

* Configure Tomcat WebDAV servlet in any webapp, for example with the following configuration : 

 <servlet>
  <servlet-name>webdav</servlet-name>
  <servlet-class>org.apache.catalina.servlets.WebdavServlet</servlet-class>
    <init-param>
      <param-name>debug</param-name>
      <param-value>0</param-value>
    </init-param>
    <init-param>
      <param-name>listings</param-name>
      <param-value>true</param-value>
    </init-param>
    <init-param>
	    <param-name>readonly</param-name>
	    <param-value>false</param-value>
	  </init-param>
  </servlet>
  <servlet-mapping>
    <servlet-name>webdav</servlet-name>
    <url-pattern>/*</url-pattern>
  </servlet-mapping>


* Attempt to connect to this webdav server using BitKinex WebDAV client (http://www.bitkinex.com)
--> BUG : connection fails

* Update the connector configuration in server.xml to reintroduce the reason phrase : 

    <Connector sendReasonPhrase="false"   [...] />

* Attempt the BitKinex connexion again
--> connection succeeed



I guess this bug will be be marked as a duplicate of #60362, but :
 * I wanted to make it obvious for any user looking for this information.
 * I think it add another argument to keep the reason phrase for legacy clients
  (even though I completely understand that Tomcat adheres the spec, and that BitKinex is not properly handling the status response)
Comment 1 Christopher Schultz 2017-06-06 15:08:15 UTC
This is not a bug in Tomcat, but in the BitKinex client.

Tomcat 8.5 has a configuration parameter on the <Connector> to re-enable the reason phrase: sendReasonPhrase

https://tomcat.apache.org/tomcat-8.5-doc/config/http.html
Comment 2 Olivier Jaquemet 2017-06-06 15:30:14 UTC
I completely agree with you on that, this is a BitKinex bug.

However 
- as you know, sendReasonPhrase option is not going to be available anymore in Tomcat 9 as a workaround. 
- I wanted to enter this bug so the tomcat team would precisely know that this regression has been introduced for this (old and probably unmaintained) WebDAV client. Just in case it would change your decision on this breaking change.

This bug now exists a reference on this subject. I did not expect more than that :)
Thanks for your work on TC.