Bug 61244 - Make cell.getCachedFormulaResultType() return CellType
Summary: Make cell.getCachedFormulaResultType() return CellType
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: 3.17-dev
Hardware: PC Mac OS X 10.1
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-30 20:13 UTC by PJ Fanning
Modified: 2017-09-28 14:11 UTC (History)
0 users


Attachments
patch (13.00 KB, patch)
2017-06-30 20:13 UTC, PJ Fanning 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description PJ Fanning 2017-06-30 20:13:11 UTC 
Created attachment 35091 [details]
patch

This method returns an int instead of an enum - some variants are marked for removal in 3.17 but not all.
I'll attach a patch because I'd like to get a review before proceeding.
Comment 1 PJ Fanning 2017-09-18 10:53:59 UTC 
Changed method to return CellType and deprecated the getCachedFormulaResultTypeEnum method.
https://svn.apache.org/repos/asf/poi/trunk@1808678
Comment 2 Dominik Stadler 2017-09-28 14:11:35 UTC 
I resolved this as I think the main goal of having getCachedFormulaResultType return CellType is done, the deprecations will lead to removal in future versions anyway.