As defaults should be the best options and knowing that: - not checking this option when using a Compilable language makes performances bad - using ${var} syntax in dynamic language makes also performances bad This option should be checked by default and an advice on using vars.get("varName") instead of ${varName} should be displayed
Created attachment 35511 [details] Patch with change default selected and add variable warning Patch with change default selected and add variable warning
T(In reply to orimarko from comment #1) > Created attachment 35511 [details] > Patch with change default selected and add variable warning > > Patch with change default selected and add variable warning Thanks for patch, but it is not working for me. When I add a JSR223PreProcessor, field is not checked. Regards
Created attachment 35521 [details] Patch for JSR cache checkbox on by default Patch for JSR cache checkbox on by default
Thanks for updated patch. But unfortunately, although there is some improvement, it is still not working for me: - Add a JSR223 Pre Processor 1, it is checked => OK - Add a JSR223 Pre Processor 2, uncheck=> OK - Go to JSR223 Pre Processor 1, it is checked => OK - Go to JSR223 Pre Processor 2, it is checked => KO Do you confirm issue on your side ? Thanks
Yes, There's an issue with my patch with more than 1 element
I'm found a RESOLVED FIXED issue #56554 which maybe make the checkbox irrelevant because it generate cache key automatically depending only on Compilable without connection to cache key check box So maybe we need to remove checkbox?
In code if there's a script file it ignores cacheKey from UI, only if it's inline script it just check if not empty cacheKey and ignore the value from UI
(In reply to orimarko from comment #7) > In code if there's a script file it ignores cacheKey from UI, only if it's > inline script it just check if not empty cacheKey and ignore the value from > UI The checkbox is still relevant. See in JSR223TestElement: if (supportsCompilable && !StringUtils.isEmpty(cacheKey)) { The checkbox is here to allow people who want to use Variables in their script to do it, mainly for backward compatibility.
Author: pmouawad Date: Fri Nov 17 21:42:18 2017 New Revision: 1815632 URL: http://svn.apache.org/viewvc?rev=1815632&view=rev Log: Bug 61640 - JSR223 Test Elements : Enable by default caching Bugzilla Id: 61640 Modified: jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java jmeter/trunk/src/core/org/apache/jmeter/util/ScriptingBeanInfoSupport.java jmeter/trunk/xdocs/changes.xml
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4530