Bug 61778 - AuthConfigFactoryImpl.detachListener() alwas returns an empty string array
Summary: AuthConfigFactoryImpl.detachListener() alwas returns an empty string array
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.5.23
Hardware: PC All
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-18 13:51 UTC by Lazar Kirchev
Modified: 2017-11-20 12:58 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lazar Kirchev 2017-11-18 13:51:33 UTC 
RegistrationContextImpl.removeListener() always returns false - it initialises the return value in the beginning, but never changes it even if the listener for removal is found. The result is that when detachListener() calls removeListener, it allways gets false, and finally does not return the correct registration id.
Comment 1 Lazar Kirchev 2017-11-18 13:52:50 UTC 
This pull request contains a test case, which illustrates the problem and a fix for it: https://github.com/apache/tomcat/pull/86
Comment 2 Mark Thomas 2017-11-20 12:58:21 UTC 
Again, many thanks for the report, patch and test case.

Fixed in:
- trunk for 9.0.2 onwards
- 8.5.x for 8.5.24 onwards