Bug 62027 - Help : Introduce property help.local to allow choosing between local (offline) documentation and online documentation
Summary: Help : Introduce property help.local to allow choosing between local (offline...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-20 14:53 UTC by Philippe Mouawad
Modified: 2018-01-29 20:18 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2018-01-20 14:53:54 UTC
Having a Browser open instead of Swing dialog where link do not open looks like a better option.
Comment 1 Philippe Mouawad 2018-01-20 15:10:15 UTC
Author: pmouawad
Date: Sat Jan 20 14:54:54 2018
New Revision: 1821747

URL: http://svn.apache.org/viewvc?rev=1821747&view=rev
Log:
Bug 62027 - Function Helper Dialog : Make Help button open browser on function documentation instead of Internal Dialog
Bugzilla Id: 62027

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2018-01-20 15:38:27 UTC
By default we use online documentation:
help.local=false
Comment 3 Philippe Mouawad 2018-01-20 15:40:35 UTC
Author: pmouawad
Date: Sat Jan 20 15:40:19 2018
New Revision: 1821753

URL: http://svn.apache.org/viewvc?rev=1821753&view=rev
Log:
Bug 62027 Help : Introduce property help.local to allow choosing between local (offline) documentation and online documentation
Bugzilla Id: 62027

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Help.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/OpenLinkAction.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/properties_reference.xml
Comment 4 Felix Schumacher 2018-01-20 16:32:54 UTC
(In reply to Philippe Mouawad from comment #0)
> Having a Browser open instead of Swing dialog where link do not open looks
> like a better option.

But that means, that users behind a firewall (most corporate users, I would assume) have to configure the jvm to use a proxy.
Comment 5 Philippe Mouawad 2018-01-23 21:35:06 UTC
(In reply to Felix Schumacher from comment #4)
> (In reply to Philippe Mouawad from comment #0)
> > Having a Browser open instead of Swing dialog where link do not open looks
> > like a better option.
> 
> But that means, that users behind a firewall (most corporate users, I would
> assume) have to configure the jvm to use a proxy.

Hi Felix,
As help is opened by default browser, I suppose his browser will have proxy configured.

But anyway , I kept the old offline mode by setting :
help.local=true

Let me know if it's ok for you.

Regards
Comment 6 Felix Schumacher 2018-01-29 20:18:02 UTC
Date: Mon Jan 29 20:17:14 2018
New Revision: 1822578

URL: http://svn.apache.org/viewvc?rev=1822578&view=rev
Log:
Display a warn message, if the desktop doesn't support the Desktop.Action.BROWSE.

This can happen, when JMeter is started on a ssh tunneled X11 server.

If the URL appears to be a component documentation, add a line that tells the user
to set the system property help.local to true.

Bugzilla Id: 62027

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/OpenLinkAction.java