Bug 62297 - Add support for multiple hosts/contexts in CrawlerSessionManagerValve
Summary: Add support for multiple hosts/contexts in CrawlerSessionManagerValve
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: All All
: P2 minor (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-12 21:12 UTC by Felix Schumacher
Modified: 2018-04-23 19:56 UTC (History)
0 users


Attachments
Support multiple hosts in one CrawlerSessionManagerValve (11.11 KB, patch)
2018-04-12 21:12 UTC, Felix Schumacher 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Schumacher 2018-04-12 21:12:30 UTC 
Created attachment 35867 [details]
Support multiple hosts in one CrawlerSessionManagerValve

When the Crawler valve is set up for multiple hosts like in
 
 <Engine>
  <Host name="localhost" ... />
  <Host name="example.invalid" ... />
  <Valve className="org.apache.catalina.valves.CrawlerSessionManagerValve" />
 </Engine>

it is only managing the sessions for "localhost" as it is using the client ip as the only key.

See https://lists.apache.org/thread.html/3eb73d69855586717fa29ec5527ca4efdf64b4465425bc8c38c8ff83@%3Cusers.tomcat.apache.org%3E for more information
Comment 1 Mark Thomas 2018-04-23 19:56:59 UTC 
Fixed in:
- trunk for 9.0.8 onwards
- 8.5.x for 8.5.31 onwards
- 8.0.x for 8.0.52 onwards
- 7.0.x for 7.0.87 onwards