Bug 62311 - only create the rewritelock when needed
Summary: only create the rewritelock when needed
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_rewrite (show other bugs)
Version: 2.5-HEAD
Hardware: PC Mac OS X 10.1
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: FixedInTrunk, PatchAvailable
Depends on:
Blocks:
 
Reported: 2018-04-18 13:16 UTC by Eric Covener
Modified: 2019-01-26 06:43 UTC (History)
0 users


Attachments
Proposed patch for trunk (2.02 KB, patch)
2018-05-07 14:56 UTC, Hank Ibell 		Details | Diff
Proposed patch for trunk (2.07 KB, patch)
2018-05-07 16:47 UTC, Hank Ibell 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Covener 2018-04-18 13:16:45 UTC 
mod_rewrite.c has a TODO wrt always creating the rewrite lock global mutex which is only needed when rewritemaps (prg: only?) are used (IIUC).

It would be nice to spare the added global mutex if it's simple.
Comment 1 Hank Ibell 2018-05-07 14:56:02 UTC 
Created attachment 35913 [details]
Proposed patch for trunk
Comment 2 Hank Ibell 2018-05-07 16:47:16 UTC 
Created attachment 35915 [details]
Proposed patch for trunk
Comment 3 Christophe JAILLET 2018-06-12 21:45:31 UTC 
This is fixed in trunk in r1831773.
Comment 4 Christophe JAILLET 2019-01-26 06:43:58 UTC 
Backported in 2.4.x in r1848681
This is part of 2.4.38