Bug 62317 - HTTP(S) Test Script Recorder: allow to add ResultSaver to created sampler
Summary: HTTP(S) Test Script Recorder: allow to add ResultSaver to created sampler
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 4.0
Hardware: All All
: P2 enhancement (vote)
Target Milestone: JMETER_5.0
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-20 07:24 UTC by kostas
Modified: 2018-04-21 06:30 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kostas 2018-04-20 07:24:37 UTC 
ProxyControl in addableInterfaces limits the classes that can be added as samplers. We have a plugin that adds a ResultSaver under each sampler recorded (returned from AbstractSamplerCreator.createChildren()). Current Jmeter 4.0 does not allow us to add this. 

Please add TestElement.class to the addableInterfaces list or any other interface that would allow the ResultSaver addition.
Comment 1 Philippe Mouawad 2018-04-20 15:30:38 UTC 
Author: pmouawad
Date: Fri Apr 20 15:30:03 2018
New Revision: 1829666

URL: http://svn.apache.org/viewvc?rev=1829666&view=rev
Log:
Bug 62317 - ProxyControl: allow to add ResultSaver as sampler
Bugzilla Id: 62317

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java

Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
Comment 2 Philippe Mouawad 2018-04-20 15:31:04 UTC 
Hello,
Can you check next nightly build and give us feedback ?
Thanks
Comment 3 kostas 2018-04-21 05:20:22 UTC 
(In reply to Philippe Mouawad from comment #2)
> Hello,
> Can you check next nightly build and give us feedback ?
> Thanks

Tested with apache-jmeter-r1829667. Works fine now,

Thanks
Comment 4 Philippe Mouawad 2018-04-21 06:30:55 UTC 
Thanks for feedback.
Comment 5 The ASF infrastructure team 2022-09-24 20:38:13 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4766