Bug 62368 - Print unparsed URI in the 'URI incorrectly encoded' error message
Summary: Print unparsed URI in the 'URI incorrectly encoded' error message
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.5-HEAD
Hardware: PC Mac OS X 10.1
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: FixedInTrunk, PatchAvailable
Depends on:
Blocks:
 
Reported: 2018-05-10 15:19 UTC by Hank Ibell
Modified: 2018-05-17 12:22 UTC (History)
0 users



Attachments
Proposed patch for trunk (728 bytes, patch)
2018-05-10 15:19 UTC, Hank Ibell
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Ibell 2018-05-10 15:19:06 UTC
Currently, the error 'URI incorrectly encoded' error message uses `r->uri` which may be unhelpful. For example, issuing the following command:

$ python -c 'print "GET /index.html?foo=bar\x0F HTTP/1.1\r\nHost: localhost:8080\r\n\r\n"' | nc localhost 8080

leads to the following error:

[Thu May 10 11:03:39.048134 2018] [core:debug] [pid 22836:tid 123145529880576] protocol.c(838): [client ::1:56524] AH03454: HTTP Request Line; URI incorrectly encoded: '/index.html'

whereas using `r->unparsed_uri` would show:

[Thu May 10 11:06:14.515688 2018] [core:debug] [pid 31904:tid 123145333022720] protocol.c(838): [client ::1:56533] AH03454: HTTP Request Line; URI incorrectly encoded: '/index.html?foo=bar\x0f'
Comment 1 Hank Ibell 2018-05-10 15:19:35 UTC
Created attachment 35925 [details]
Proposed patch for trunk
Comment 2 Eric Covener 2018-05-17 12:22:12 UTC
Thanks, committed in r1831772