Bug 62624 - Regression in VBAMacroreader in 4.0.0-SNAPSHOT NPE in readProjectcProperties
Summary: Regression in VBAMacroreader in 4.0.0-SNAPSHOT NPE in readProjectcProperties
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 4.0.x-dev
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-14 18:56 UTC by Tim Allison
Modified: 2018-10-29 15:49 UTC (History)
0 users


Attachments
triggering document (122.08 KB, application/zip)
2018-08-14 18:56 UTC, Tim Allison 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Allison 2018-08-14 18:56:35 UTC 
Created attachment 36091 [details]
triggering document

Minor regression in Macro reader

java.lang.NullPointerException
	at org.apache.poi.poifs.macros.VBAMacroReader.readProjectProperties(VBAMacroReader.java:606)
	at org.apache.poi.poifs.macros.VBAMacroReader.findProjectProperties(VBAMacroReader.java:335)
	at org.apache.poi.poifs.macros.VBAMacroReader.readMacroModules(VBAMacroReader.java:115)
	at org.apache.poi.poifs.macros.VBAMacroReader.readMacros(VBAMacroReader.java:133)
	at org.apache.tika.parser.microsoft.OfficeParser.extractMacros(OfficeParser.java:323)

In this one file 'module' is null at this point:
                        module = (VBAMacroReader.ModuleImpl)modules.get(tokens[1]);
                        module.moduleType = ModuleType.Module;
Comment 1 Tim Allison 2018-10-29 15:01:18 UTC 
We need to add code to read name mappings from the PROJECTwm stream.

2.2.8 PROJECTwm Stream and 2.3.3 PROJECTwm Stream

Will commit fix once integration tests pass.
Comment 2 Tim Allison 2018-10-29 15:49:49 UTC 
r1845138