Bug 62806 - ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode
Summary: ModuleController cloning by Run behaves differently wether in GUI or Non GUI ...
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 major (vote)
Target Milestone: JMETER_5.1
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2018-10-08 09:09 UTC by UbikLoadPack support
Modified: 2018-11-06 14:04 UTC (History)
1 user (show)


Attachments
Test plan screenshot (161.58 KB, image/png)
2018-10-08 09:09 UTC, UbikLoadPack support 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description UbikLoadPack support 2018-10-08 09:09:56 UTC 
Created attachment 36191 [details]
Test plan screenshot

Hello,
Working with 3rd party plugin we noticed a difference in behaviour between GUI and NON GUI mode.

One particular 3rd party component that implemented NoThreadClone was behaving in a wrong way in NON GUI Mode.
See:
- https://groups.google.com/forum/#!topic/jmeter-plugins/YEU-nstQ4oc

After further analysis it appears issue is in Core JMeter .
When running a test in GUI mode , a clone tree withour honouring NoThreadClone happens:

- https://github.com/apache/jmeter/blob/v5_0/src/core/org/apache/jmeter/gui/action/Start.java#L205

But in GUI mode, so such thing happens.

This triggers an issue when you use at least twice a ModuleController that references a Component that implements NoThreadClone.

In the attached test plan, we have:
- TG-Participant1-Input using a ModuleController-Sender referencing Simple-Controller-Referenced
- TG-Participant2-Input using a ModuleController-Sender referencing Simple-Controller-Referenced

We end up having in NON GUI only 1 instance of NoThreadClone-Element while in GUI mode we have 2.
Comment 1 Philippe Mouawad 2018-10-08 14:58:24 UTC 
Author: pmouawad
Date: Mon Oct  8 14:57:46 2018
New Revision: 1843158

URL: http://svn.apache.org/viewvc?rev=1843158&view=rev
Log:
BUG 62806 : ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode
Contributed by UbikLoadPack
Bugzilla Id: 62806

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2018-11-06 14:04:46 UTC 
Author: pmouawad
Date: Tue Nov  6 13:39:15 2018
New Revision: 1845917

URL: http://svn.apache.org/viewvc?rev=1845917&view=rev
Log:
Bug 62806 ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode.
Reinstate old method signature to avoid NoSuchMethodError in calling plugins and deprecate it
Bugzilla Id: 62806

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
Comment 3 The ASF infrastructure team 2022-09-24 20:38:14 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4889