Bug 63082 - Use utf-8 for properties in sources
Summary: Use utf-8 for properties in sources
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.0
Hardware: All All
: P2 enhancement (vote)
Target Milestone: JMETER_5.1
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2019-01-17 09:19 UTC by Felix Schumacher
Modified: 2019-01-17 10:16 UTC (History)
0 users



Attachments
Use native2ascii while compiling the sources. (15.63 KB, patch)
2019-01-17 09:19 UTC, Felix Schumacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Schumacher 2019-01-17 09:19:53 UTC
Created attachment 36377 [details]
Use native2ascii while compiling the sources.

To ease maintenance of the properties files, they should be edited as utf-8 encoded files and transformed to escaped format while building.

https://github.com/apache/jmeter/pull/437 does exactly that.
Comment 1 Felix Schumacher 2019-01-17 10:00:29 UTC
Will be included in version 5.1

Date: Thu Jan 17 09:32:21 2019
New Revision: 1851506

URL: http://svn.apache.org/viewvc?rev=1851506&view=rev
Log:
Use utf-8 for properties files in source

Part of #437 on github.

Bugzilla Id: 63082

Modified:
    jmeter/trunk/build.xml
    jmeter/trunk/xdocs/changes.xml
Date: Thu Jan 17 09:45:57 2019
New Revision: 1851507

URL: http://svn.apache.org/viewvc?rev=1851507&view=rev
Log:
Converted properties to utf8

Used the tool native2ascii to convert the ascii encoded properties
to utf-8. It should now be easier for language translators to edit those
files.

$ find src/ -name "*.properties"  | while read i
  do
    native2ascii -reverse $i $i.new && mv $i.new $i
  done

Related to #437 on github
Bugzilla Id: 63082

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertionResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertionResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertionResources_pl.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertionResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertionResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertionResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertionResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/JSR223AssertionResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/JSR223AssertionResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/assertions/JSR223AssertionResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_es.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_pl.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_zh_TW.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/RandomVariableConfigResources_es.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/RandomVariableConfigResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/RandomVariableConfigResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/config/RandomVariableConfigResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProcessorResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProcessorResources_pl.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProcessorResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_pl.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessorResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessorResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessorResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BSFPreProcessorResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BSFPreProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BSFPreProcessorResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BSFPreProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessorResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessorResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessorResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BSFTimerResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BSFTimerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BSFTimerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_es.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_ja.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_zh_TW.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/JSR223TimerResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/JSR223TimerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/JSR223TimerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_es.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/poissonarrivals/PreciseThroughputTimerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/timers/poissonarrivals/PreciseThroughputTimerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BSFListenerResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BSFListenerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BSFListenerResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BSFListenerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellListenerResources_de.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellListenerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellListenerResources_pt_BR.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellListenerResources_tr.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellListenerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/JSR223ListenerResources.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/JSR223ListenerResources_fr.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/JSR223ListenerResources_zh_CN.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/utils/colors.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_de.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_es.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_ja.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_no.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pl.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pt_BR.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_tr.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_zh_CN.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_zh_TW.properties
    jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2Resources.properties
    jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2Resources_tr.properties
    jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2Resources_zh_TW.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources_es.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources_fr.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources_pt_BR.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources_tr.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources_zh_TW.properties
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BSFSamplerResources_fr.properties
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/BSFSamplerResources_zh_CN.properties
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JSR223SamplerResources.properties
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JSR223SamplerResources_fr.properties
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JSR223SamplerResources_zh_CN.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_es.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_fr.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_pt_BR.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_tr.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_zh_TW.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPostProcessorResources_fr.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPostProcessorResources_zh_CN.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPreProcessorResources.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPreProcessorResources_fr.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPreProcessorResources_zh_CN.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources_es.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources_fr.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources_pt_BR.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources_tr.properties
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources_zh_TW.properties
    jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/config/MongoSourceElementResources_fr.properties
    jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/sampler/MongoScriptSamplerResources_fr.properties
Date: Thu Jan 17 09:59:00 2019
New Revision: 1851508

URL: http://svn.apache.org/viewvc?rev=1851508&view=rev
Log:
Correct double encoded characters in properties

These double encoded characters were introduced a long time ago, but
nobody seems to have noticed them.

As I don't speak french, it would be great if someone else could look at
this commit :)

One brazilian properties file has still some wrong characters that can be
found by

$ grep '√' -r src/

Closes #437 on github
Bugzilla Id: 63082

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
Comment 2 Felix Schumacher 2019-01-17 10:15:54 UTC
Date: Thu Jan 17 10:15:14 2019
New Revision: 1851509

URL: http://svn.apache.org/viewvc?rev=1851509&view=rev
Log:
Correct some spelling mistakes in german translation

Related to #437
Bugzilla Id: 63082

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_de.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_de.properties