Bug 64959 - [PATCH] PackagePart#flush is unused
Summary: [PATCH] PackagePart#flush is unused
Status: RESOLVED WONTFIX
Alias: None
Product: POI
Classification: Unclassified
Component: OPC (show other bugs)
Version: 4.1.2-FINAL
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2020-12-06 01:25 UTC by Marius Volkhart
Modified: 2021-10-31 09:25 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Volkhart 2020-12-06 01:25:34 UTC 
This method is never called by the POI code, and none of the built-in implementations have meaningful implementation of the method.

PackagePropertiesPart#flush() was called in one location, but as the implementation is empty, the call is unnecessary.

There's no bug here, rather, there's just code that is essentially dead.
Comment 1 Marius Volkhart 2020-12-06 01:27:57 UTC 
PR available https://github.com/apache/poi/pull/202
Comment 2 PJ Fanning 2021-10-31 09:25:20 UTC 
I don't think we want to implement this - Marius closed the PR - Marius, please feel free to reopen if you feel strongly about this.