Bug 65674 - Missing check if PictureShape contains video
Summary: Missing check if PictureShape contains video
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 5.0.x-dev
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-09 07:48 UTC by Vadim
Modified: 2021-11-21 17:29 UTC (History)
1 user (show)


Attachments
Patch with a test presentation file (183.63 KB, patch)
2021-11-09 07:57 UTC, Vadim 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim 2021-11-09 07:48:32 UTC 
Recently I needed to check if Picture on a slide is actually embedded video, so I implemented method isSetVideoFile() of XSLFPictureShape instance.
Also added method for getting Link attribute to video.
Comment 1 Vadim 2021-11-09 07:57:11 UTC 
Created attachment 38083 [details]
Patch with a test presentation file
Comment 2 PJ Fanning 2021-11-09 10:42:13 UTC 
Thanks - I added r1894860 - I renamed your methods a little - if you feel strongly about the method comments, please get back to us
Comment 3 Dominik Stadler 2021-11-21 17:29:07 UTC 
Setting to resolved as the core change is done now, please reopen if there is still something missing.