Bug 66157 - Code Textbox Text Colour
Summary: Code Textbox Text Colour
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.5
Hardware: PC All
: P2 normal (vote)
Target Milestone: JMETER_5.5
Assignee: JMeter issues mailing list
Keywords: FixedInTrunk, PatchAvailable
Depends on:
Reported: 2022-07-04 12:03 UTC by nathan88wise
Modified: 2022-08-26 22:18 UTC (History)
0 users

JSR223 Textbox input with Darcula (71.06 KB, image/png)
2022-07-04 12:03 UTC, nathan88wise
How it looks in my machine with current trunk (66.70 KB, image/png)
2022-07-08 09:54 UTC, Felix Schumacher

Note You need to log in before you can comment on or make changes to this bug.
Description nathan88wise 2022-07-04 12:03:09 UTC
Created attachment 38333 [details]
JSR223 Textbox input with Darcula

When you use any theme, the default text colour (black) is there no matter the theme. If you use a dark theme - it becomes a nightmare to read the text. It's also quite hard to read the other coloured text.

The current solution we're using it to downgrade all of the DarkLAF jars to  v2.4.8 as suggested by this Stack Overflow post: https://stackoverflow.com/questions/67430501/jmeter-change-font-colour/68407296#68407296

It would be nice if we didn't have to do this.
Comment 1 Felix Schumacher 2022-07-05 14:22:17 UTC
Thanks for the report. I opened https://github.com/apache/jmeter/pull/719 with a fix.
Comment 2 Felix Schumacher 2022-07-07 14:53:40 UTC
@Nathan, can you check next nightly and report back, if this is fixed?

commit b914b713640ffd88b935786d13c0acce51b04259
AuthorDate: Tue Jul 5 16:16:38 2022 +0200

    Correct theme for darklaf on rsyntaxtextarea
    The id of the theme has been changed to all lowercase
    Bugzilla Id: 66517
    Closes #719
 .../src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java  | 2 +-
 xdocs/changes.xml                                                       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Comment 3 nathan88wise 2022-07-08 08:26:53 UTC
Just tried the latest one (r236-7548000b1f1dc6708e2186afa721df71057b8082) and it looked the exact same to me - not sure if this one has your fix in it though.
Comment 4 Felix Schumacher 2022-07-08 09:54:10 UTC
Created attachment 38336 [details]
How it looks in my machine with current trunk
Comment 5 Felix Schumacher 2022-07-08 09:55:59 UTC
Maybe the nightly has not catched up with trunk. Could you try the builds from trunk: https://ci-builds.apache.org/job/JMeter/job/JMeter-trunk/lastSuccessfulBuild/artifact/src/dist/build/distributions/ ?
Comment 6 nathan88wise 2022-07-08 10:19:08 UTC
Tried the trunk build and messed around with some other elements in a test plan.
Looks good to me!
Comment 7 Brian Tully 2022-08-26 21:02:19 UTC
I had posted several related bugs related to Darklaf and dark themes, where textareas were unreadable due to the dark text against a dark background. In my bug reports I was referring to the textareas within View Results Tree that use syntax coloring (e.g., request headers, response headers, etc).



I also filed a bug within the Darkflaf project at https://github.com/weisJ/darklaf/issues/328 where Jannis was kind enough to point me to https://github.com/apache/jmeter/commit/b914b713640ffd88b935786d13c0acce51b04259 which lead me to this bug report.

I am hoping that this really fixes the issue so that I can finally upgrade from JMeter 5.2.1.

I will also try testing the trunk build to make sure it's also working for me on my Mac. I know this bug is listed as resolved/closed, but I'll report back with my results and reopen if needed. 

Comment 8 Brian Tully 2022-08-26 22:18:41 UTC
I'm confirming that it is fixed for me as well, on my Mac, with the latest trunk build.

Is there any way to use the same rsyntaxtextarea class for the Response Body textarea within View Results Tree? Right now it just shows as plain text in sans-serif font, which is not exactly helpful when debugging. 

I've updated my old bug at https://bz.apache.org/bugzilla/show_bug.cgi?id=65187 to see if that enhancement might be doable now that Darklaf and rsyntaxtextarea is fixed in trunk :)
Comment 9 The ASF infrastructure team 2022-09-24 20:38:23 UTC
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/5687