Bug 66206 - TestErrorReportValve test is failing on a non-English PC
Summary: TestErrorReportValve test is failing on a non-English PC
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 10
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: ------
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-11 14:44 UTC by Han Li
Modified: 2022-08-11 15:43 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Han Li 2022-08-11 14:44:41 UTC 
org.apache.catalina.valves.TestErrorReportValve#testBug53071

```
Assert.assertTrue(res.toString().contains("<p><b>Message</b> " +
                ErrorServlet.ERROR_TEXT + "</p>"));
```
org.apache.catalina.valves.ErrorReportValve#report
```
sb.append("<p><b>");
sb.append(smClient.getString("errorReportValve.message"));
sb.append("</b> ");
```
Since the local of my OS is zh-CN, the response contains `<p><b>信息</b> .... ` instead of `<p><b>Message</b>.... ', so this test would fail.


Similar to https://bz.apache.org/bugzilla/show_bug.cgi?id=63403
Comment 1 Mark Thomas 2022-08-11 15:43:36 UTC 
- 10.1.x for 10.1.0-M18 onwards
- 10.0.x for 10.0.24 onwards
-  9.0.x for  9.0.66 onwards
-  8.5.x for  8.5.83 onwards

Thanks for the report and the PR.